gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081249124
##########
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##########
@@ -55,4 +60,11 @@
*/
List<String> findVersions( Artifact artifact );
+ /**
+ * List all available artifacts this workspace repository manages.
+ *
+ * @return a stream of artifacts in no particular order
+ */
+ Stream<Artifact> listArtifacts();
Review Comment:
> After reconsidering this change, I am -1 on it (now or 2.x), reasons:
>
> * I see no point of adding new methods to resolver interface that resolver
itself is NOT going to use
> * obviously, these methods are needed to some "integrator" of resolver,
but as can be seen on example of Maven (as one of integrator), one can
introduces specific reader (in maven it is MavenWorkspaceReader) and decorate
it by adding specific methods to it
> * also,by adding methods here we would force any other integrator to
implement them even if they would not need it (as resolver itself is not using
these either).
@laeubi why do you need this additional method if you will the eclipse
integration provides both the implementation and the caller ? I fail to
understand the benefit here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
