gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081479002
##########
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##########
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+import java.util.stream.Stream;
import org.eclipse.aether.artifact.Artifact;
/**
* Manages a repository backed by the IDE workspace, a build session or a
similar ad-hoc collection of artifacts.
+ * <em>Note:</em> Implementors are strongly advised to inherit from {@link
AbstractWorkspaceReader} instead of directly
+ * implementing this interface.
*
* @see org.eclipse.aether.RepositorySystemSession#getWorkspaceReader()
+ * @noimplement This interface is not intended to be implemented by clients.
+ * @noextend This interface is not intended to be extended by clients.
Review Comment:
I _think_ `client` is to be understood in the context of the resolver, i.e.
any piece of software using the resolver. The main client is maven, and it's
the one implementing this interface. This interface is pure SPI and _should be
provided_ by the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
