slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1174597747
##########
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##########
@@ -293,10 +294,7 @@ protected Archiver createArchiver(
final List<FileSelector> extraSelectors = new ArrayList<>();
final List<ArchiveFinalizer> extraFinalizers = new ArrayList<>();
if (archiver instanceof JarArchiver) {
- if (mergeManifestMode != null) {
- ((JarArchiver) archiver)
-
.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
- }
+ configureJarArchiver((JarArchiver) archiver, mergeManifestMode,
configSource.getJarArchiveConfiguration());
Review Comment:
yes - currently ear, rar, war
https://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/jar/JarArchiver.html
I would like to extends another types, eg for car we only have a UnArchiver
https://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/car/package-summary.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
