hboutemy commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1182127757
##########
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##########
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+ private void configureJarArchiver(
+ JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+ if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+ }
+
+ archiver.setMinimalDefaultManifest(true);
Review Comment:
what if mergeManifestMode is set to `skip`?
I find it surprising to have `true` hardcoded
##########
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##########
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+ private void configureJarArchiver(
+ JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+ if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+ }
+
+ archiver.setMinimalDefaultManifest(true);
+
+ if (configuration != null) {
+ archiver.setCompress(configuration.isCompress());
+ archiver.setForced(configuration.isForced());
+ archiver.setIndex(configuration.isIndex());
Review Comment:
does this have to be checked against mergeManifestmode or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
