slawekjaranowski commented on code in PR #134:
URL:
https://github.com/apache/maven-assembly-plugin/pull/134#discussion_r1182400577
##########
src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java:
##########
@@ -351,6 +349,23 @@ protected Archiver createArchiver(
return archiver;
}
+ private void configureJarArchiver(
+ JarArchiver archiver, String mergeManifestMode,
MavenArchiveConfiguration configuration) {
+
+ if (mergeManifestMode != null) {
+
archiver.setFilesetmanifest(JarArchiver.FilesetManifestConfig.valueOf(mergeManifestMode));
+ }
+
+ archiver.setMinimalDefaultManifest(true);
Review Comment:
default value for `mergeManifestMode` is `skip`
`setMinimalDefaultManifest` has only effect on code:
https://github.com/codehaus-plexus/plexus-archiver/blob/40b1b12e849ef62021e9d9787add3db7f34267af/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java#L767
If we omit `addDefaultEntries` or set it with `true` - maven-archiver will
add own Manifest
So IMHO can be hardcoded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
