[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721881#comment-17721881
]
ASF GitHub Bot commented on MPIR-431:
-------------------------------------
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191590748
##########
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##########
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+ private String getHighestVersion(double version) {
+ if (version >= 1.0d) {
Review Comment:
Ha, you are right! Can we move to a separate issue? I think the wiser step
would be a change from `double` to `Double` and use `null` truly.
> Dependency file details section: segregate Java version column into execution
> and test versions
> -----------------------------------------------------------------------------------------------
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
> Reporter: Gabriel Belingueres
> Assignee: Michael Osipov
> Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
