[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724729#comment-17724729
]
ASF GitHub Bot commented on MPIR-431:
-------------------------------------
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199875668
##########
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##########
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
}
} else {
tableRow(hasSealed, new String[] {
- artifactFile.getName(),
- fileLengthDecimalFormat.format(artifactFile.length()),
- "",
- "",
- "",
- "",
- "",
- ""
+ artifactFile.getName(),
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""
Review Comment:
I'll fix it
##########
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##########
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
private void createExceptionInfoTableRow(Artifact artifact, File
artifactFile, Exception e, boolean hasSealed) {
tableRow(
hasSealed,
- new String[] {artifact.getId(),
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+ new String[] {artifact.getId(),
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});
Review Comment:
I'll fix it
> Dependency file details section: segregate Java version column into execution
> and test versions
> -----------------------------------------------------------------------------------------------
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
> Reporter: Gabriel Belingueres
> Assignee: Michael Osipov
> Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
