timtebeek commented on code in PR #146:
URL: https://github.com/apache/maven-archetype/pull/146#discussion_r1193122274
##########
archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java:
##########
@@ -569,7 +569,7 @@ private void processFilesetModule( final String
rootArtifactId, final String art
processFilesetModule( rootArtifactId, moduleArtifactId,
archetypeResources, new File(
moduleOutputDirectoryFile, Constants.ARCHETYPE_POM ),
archetypeZipFile,
- ( StringUtils.isEmpty( moduleOffset ) ? "" :
( moduleOffset + "/" ) )
+ ( (moduleOffset == null ||
moduleOffset.isEmpty()) ? "" : ( moduleOffset + "/" ) )
Review Comment:
```suggestion
( ( moduleOffset == null ||
moduleOffset.isEmpty() ) ? "" : ( moduleOffset + "/" ) )
```
##########
archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java:
##########
@@ -415,7 +414,7 @@ static boolean matchesLayout( String repoLayout, String
mirrorLayout )
boolean result = false;
// simple checks first to short circuit processing below.
- if ( StringUtils.isEmpty( mirrorLayout ) || WILDCARD.equals(
mirrorLayout ) )
+ if ( (mirrorLayout == null || mirrorLayout.isEmpty()) ||
WILDCARD.equals( mirrorLayout ) )
Review Comment:
```suggestion
if ( ( mirrorLayout == null || mirrorLayout.isEmpty() ) ||
WILDCARD.equals( mirrorLayout ) )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
