timtebeek commented on code in PR #146:
URL: https://github.com/apache/maven-archetype/pull/146#discussion_r1193122378
##########
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/creation/DefaultArchetypeCreationConfigurator.java:
##########
@@ -144,7 +144,7 @@ public Properties configureArchetypeCreation( MavenProject
project, Boolean inte
getLogger().debug( "Asking for project's package" );
archetypeConfiguration.setProperty(
Constants.PACKAGE,
-
archetypeCreationQueryer.getPackage( StringUtils.isEmpty( resolvedPackage ) ?
archetypeConfiguration.getDefaultValue( Constants.PACKAGE )
+
archetypeCreationQueryer.getPackage( (resolvedPackage == null ||
resolvedPackage.isEmpty()) ? archetypeConfiguration.getDefaultValue(
Constants.PACKAGE )
Review Comment:
```suggestion
archetypeCreationQueryer.getPackage( ( resolvedPackage == null ||
resolvedPackage.isEmpty() ) ? archetypeConfiguration.getDefaultValue(
Constants.PACKAGE )
```
##########
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java:
##########
@@ -210,7 +210,7 @@ else if ( archetypeArtifactManager.isOldArchetype(
ad.getGroupId(), ad.getArtifa
{
String defaultValue =
archetypeConfiguration.getDefaultValue( requiredProperty );
- if ( Constants.PACKAGE.equals( requiredProperty )
&& StringUtils.isEmpty( defaultValue ) )
+ if ( Constants.PACKAGE.equals( requiredProperty )
&& (defaultValue == null || defaultValue.isEmpty()) )
Review Comment:
```suggestion
if ( Constants.PACKAGE.equals( requiredProperty
) && ( defaultValue == null || defaultValue.isEmpty() ) )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
