[
https://issues.apache.org/jira/browse/MNG-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725068#comment-17725068
]
ASF GitHub Bot commented on MNG-7789:
-------------------------------------
gnodet commented on code in PR #1115:
URL: https://github.com/apache/maven/pull/1115#discussion_r1200735153
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -46,6 +42,13 @@
@Singleton
@Named
public final class DefaultPluginValidationManager extends AbstractEventSpy
implements PluginValidationManager {
+ /**
+ * The collection of "G:A" combinations that do NOT belong to Maven Core,
hence, should be excluded from
+ * "expected in provided scope" type of checks.
+ */
+ static final Collection<String> EXPECTED_PROVIDED_SCOPE_EXCLUSIONS_GA =
+ Collections.unmodifiableCollection(Arrays.asList(
+ "org.apache.maven:maven-archiver",
"org.apache.maven:maven-jxr", "org.apache.maven:plexus-utils"));
Review Comment:
I know those values have not changed, but is the `org.apache.maven` groupId
expected for `plexus-utils` ?
> Plugin Dependency Validations use wrong data set
> ------------------------------------------------
>
> Key: MNG-7789
> URL: https://issues.apache.org/jira/browse/MNG-7789
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
> Affects Versions: 3.9.2
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
>
> They all use pluginDescriptor/dependencies, that are NOT used to calculate
> plugin dependencies, POM is. Except for one new check (the one added in
> MNG-7786) the others should be refactored to use POM instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
