cstamas commented on code in PR #294:
URL: https://github.com/apache/maven-resolver/pull/294#discussion_r1213125643
##########
maven-resolver-named-locks-hazelcast/pom.xml:
##########
@@ -39,21 +39,23 @@
<dependencies>
<dependency>
<groupId>org.apache.maven.resolver</groupId>
- <artifactId>maven-resolver-api</artifactId>
+ <artifactId>maven-resolver-named-locks</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.maven.resolver</groupId>
- <artifactId>maven-resolver-named-locks</artifactId>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
- <version>5.1.4</version>
+ <version>5.3.0</version>
</dependency>
<dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
- <optional>true</optional>
+ <scope>provided</scope>
</dependency>
Review Comment:
No, just like any maven plugin (w/ these scopes) will not resolve all the
needed dependencies outside of Maven. IMHO these artifacts are meant for one
thing: to be dropped into `${maven.home}/lib/ext` and nothing more. More
cautiously one could say "to be dropped into existing (and working) resolver
classpath", but then again scope is right, as "working classpath" of resolver
HAS this artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
