cstamas commented on code in PR #294:
URL: https://github.com/apache/maven-resolver/pull/294#discussion_r1213128277
##########
maven-resolver-named-locks-hazelcast/pom.xml:
##########
@@ -39,21 +39,23 @@
<dependencies>
<dependency>
<groupId>org.apache.maven.resolver</groupId>
- <artifactId>maven-resolver-api</artifactId>
+ <artifactId>maven-resolver-named-locks</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.maven.resolver</groupId>
- <artifactId>maven-resolver-named-locks</artifactId>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
- <version>5.1.4</version>
+ <version>5.3.0</version>
</dependency>
<dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
- <optional>true</optional>
+ <scope>provided</scope>
</dependency>
Review Comment:
One may consider these as "manually installed plugins for resolver" as
that's what both do (hazelcast and redisson), they add themselves and their
(not yet present) dependencies, like hazelcast and redisson w/ transitive hull.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
