[ 
https://issues.apache.org/jira/browse/MNG-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773710#comment-17773710
 ] 

ASF GitHub Bot commented on MNG-7901:
-------------------------------------

gnodet commented on code in PR #1274:
URL: https://github.com/apache/maven/pull/1274#discussion_r1352605710


##########
maven-repository-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/io/xpp3/MetadataXpp3Reader.java:
##########
@@ -26,22 +26,23 @@
 import java.io.Reader;
 
 import org.apache.maven.artifact.repository.metadata.Metadata;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
 
 /**
- * Provide public methods from {@link 
org.apache.maven.artifact.repository.metadata.io.MetadataXpp3Reader}
+ * Provide public methods from {@link 
org.apache.maven.artifact.repository.metadata.io.MetadataStaxReader}
  *
  * @deprecated Maven 3 compatability
  */
 @Deprecated

Review Comment:
   Ah, I think you're right.  Those two classes were removed when introducing 
the v4 api, later brought back to restore compatibility with Maven 3 but in a 
deprecated state.  So this is definitely a deprecation to switch to the v4 api. 
 Might be slightly premature though...
   Anyway the layout is the same as for the maven model: the old v3 model for 
metadata is layered on top of the immutable one for v4.  Maybe the v4 generated 
model should be moved into the a `api/maven-api-metadata` module ?





> Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer
> ----------------------------------------------------------
>
>                 Key: MNG-7901
>                 URL: https://issues.apache.org/jira/browse/MNG-7901
>             Project: Maven
>          Issue Type: Bug
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 4.0.0-alpha-8, 4.0.0
>
>
> {{writer.vm}} should be only used for {{MavenXpp3Writer}} we have hardcode 
> schema location for Maven model.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to