[
https://issues.apache.org/jira/browse/MNG-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773712#comment-17773712
]
ASF GitHub Bot commented on MNG-7901:
-------------------------------------
slawekjaranowski commented on code in PR #1274:
URL: https://github.com/apache/maven/pull/1274#discussion_r1352608061
##########
maven-repository-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/io/xpp3/MetadataXpp3Reader.java:
##########
@@ -26,22 +26,23 @@
import java.io.Reader;
import org.apache.maven.artifact.repository.metadata.Metadata;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
/**
- * Provide public methods from {@link
org.apache.maven.artifact.repository.metadata.io.MetadataXpp3Reader}
+ * Provide public methods from {@link
org.apache.maven.artifact.repository.metadata.io.MetadataStaxReader}
*
* @deprecated Maven 3 compatability
*/
@Deprecated
Review Comment:
Maybe we should not add a technology used by parser in class name.
When some days we figure out to use SuperFoo Xml parser we next change
classes from MetadataStaxReader to MetadataSuperFooReader again?
Maybe name should be like MetadataXmlReader
> Use MetadataStaxReader/Writer in MetadataXpp3Reader/Writer
> ----------------------------------------------------------
>
> Key: MNG-7901
> URL: https://issues.apache.org/jira/browse/MNG-7901
> Project: Maven
> Issue Type: Bug
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 4.0.0-alpha-8, 4.0.0
>
>
> {{writer.vm}} should be only used for {{MavenXpp3Writer}} we have hardcode
> schema location for Maven model.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
