[
https://issues.apache.org/jira/browse/MCOMPILER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782798#comment-17782798
]
ASF GitHub Bot commented on MCOMPILER-542:
------------------------------------------
jorsol opened a new pull request, #208:
URL: https://github.com/apache/maven-compiler-plugin/pull/208
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> clean JDK patch version in module-info.class
> --------------------------------------------
>
> Key: MCOMPILER-542
> URL: https://issues.apache.org/jira/browse/MCOMPILER-542
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Affects Versions: 3.11.0
> Reporter: Herve Boutemy
> Priority: Major
>
> as seen in MJAR-275, JDK patch version in module-info.class is not included
> only when building with a newer JDK release using "--release" flag, see
> https://github.com/jvm-repo-rebuild/module-info
> we need an issue in JDK to get a proper fix
> and waiting for. that, we need a workaround to drop the JDK patch version in
> other cases: we'll need to define were is the best place --
> m-jar-p?m-compiler-p? other?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
