[ 
https://issues.apache.org/jira/browse/MCOMPILER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789226#comment-17789226
 ] 

Jorge Solórzano commented on MCOMPILER-542:
-------------------------------------------

I would call it a workaround more than a hack, but anyway, if the fix ships in 
22 (I doubt it will in 21), we can add the conditional, but we are not there 
yet, so even if the workaround applies to every version right now, it should 
not make any difference between the fix in the JDK and here.

Actually, the only advantage of the JDK fix is that it would not require ASM 
upgrades on every major version (that it's actually required now anyway), other 
than that it should be a perfectly valid workaround.

In any case, I could add the info message on every modification (even if I 
would prefer as debug).

> clean JDK patch version in module-info.class
> --------------------------------------------
>
>                 Key: MCOMPILER-542
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-542
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.11.0
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.12.0
>
>
> as seen in MJAR-275, JDK patch version in module-info.class is NOT included 
> only when building with a newer JDK release using "--release" flag, see 
> [https://github.com/jvm-repo-rebuild/module-info]
> issue [https://bugs.openjdk.org/browse/JDK-8318913] created in JDK to get a 
> proper fix at javac level (probably for Java 22)
> and waiting for that, we need a workaround to drop the JDK patch version in 
> other cases: we'll need to define where is the best place – 
> m-jar-p?m-compiler-p? other?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to