rmannibucau commented on code in PR #950:
URL: https://github.com/apache/maven/pull/950#discussion_r1386957429


##########
maven-core/pom.xml:
##########
@@ -144,6 +144,12 @@ under the License.
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
     </dependency>
+    <dependency>

Review Comment:
   Well, this is not really the same, here you build an user facing feature 
(I'm thinking to extensions more than mojo) so it has to support this 
transparent java upgrade.
   For "us" we don't care since our bytecode will always be consistent as you 
explained.
   This is why I think we should generate the proxies at build time in out 
tooling stack more than at runtime - and I don't think doing it only for user 
code would be good.
   
   this is my reasoning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to