gnodet commented on code in PR #950:
URL: https://github.com/apache/maven/pull/950#discussion_r1387041873
##########
maven-core/pom.xml:
##########
@@ -144,6 +144,12 @@ under the License.
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
Review Comment:
I'm not following. What are you worried about exactly ? ASM is already
used, so it's just another usage. Related to class loaders, this PR does not
change much, it simply adds byte buddy and objenesis to the maven core
classloader, but ASM is already present, so there's actually no change related
to ASM.
In the simplier form, I would have used a JDK `Proxy`, but this looks too
limited, so I went directly with bytebuddy, but the effect is the same. It's
transparent for the user.
I really don't get your worry as the classloader is nearly unchanged and
proxies are only generated when actually needed (i.e. with the current plugins,
it should never happen).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
