[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784362#comment-17784362
]
ASF GitHub Bot commented on MNG-7924:
-------------------------------------
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387813713
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##########
@@ -51,14 +51,21 @@ public interface Type {
* Returns the dependency type id.
* The id uniquely identifies this <i>dependency type</i>.
*
- * @return the id of this type
+ * @return the id of this type, never {@code null}.
*/
String getId();
+ /**
+ * Returns the dependency type language.
+ *
+ * @return the language of this type, never {@code null}.
+ */
+ String getLanguage();
Review Comment:
I may remove this, as it is used ONLY in conversion of Type to AH, but am
unsure is it used anywhere at all...
We can always return it using DependencyProperties where Map<String, String>
can not only hold "flags" (string values of "true" and "false") but something
else as well....
> Better control over and better integration with Resolver
> --------------------------------------------------------
>
> Key: MNG-7924
> URL: https://issues.apache.org/jira/browse/MNG-7924
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0-alpha-9
>
>
> Integrate better and obtain better control over Resolver. These changes did
> stem from "[JPMS module
> experiment|https://cwiki.apache.org/confluence/display/MAVEN/Experiment+-+Explicit+JPMS+support]"
> and are considered improvement but *does not implement any functionality*
> related to JPMS module support.
> Changes:
> * Maven4 should stop "disconnected coexistence" of two type systems
> (ArtifactHandlers and Resolver ArtifactTypeRegistry), it should unify them.
> * Maven4 Core should provide generic and extensible means to introduce new
> artifact types (fully in extension, and extension should get extended data
> via "roundtrip" in core/resolver)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)