[ 
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784379#comment-17784379
 ] 

ASF GitHub Bot commented on MNG-7924:
-------------------------------------

cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387849231


##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java:
##########
@@ -59,8 +62,37 @@ private MavenRepositorySystemUtils() {
      * the session with authentication, mirror, proxy and other information 
required for your environment.
      *
      * @return The new repository system session, never {@code null}.
+     * @deprecated This method is deprecated.
      */
+    @Deprecated
     public static DefaultRepositorySystemSession newSession() {
+        DefaultArtifactTypeRegistry stereotypes = new 
DefaultArtifactTypeRegistry();
+        stereotypes.add(new DefaultArtifactType("pom"));

Review Comment:
   Deprecation is probably wrong.... is "deprecated" from Maven POV as it wants 
to inject own TypeRegistry, but again, code integrating Maven Resolver (like 
MIMA) does not have new Maven API on classpath, and it will want to stick to 
"pure" resolver classes...





> Better control over and better integration with Resolver
> --------------------------------------------------------
>
>                 Key: MNG-7924
>                 URL: https://issues.apache.org/jira/browse/MNG-7924
>             Project: Maven
>          Issue Type: Task
>          Components: Artifacts and Repositories
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0-alpha-9
>
>
> Integrate better and obtain better control over Resolver. These changes did 
> stem from "[JPMS module 
> experiment|https://cwiki.apache.org/confluence/display/MAVEN/Experiment+-+Explicit+JPMS+support]";
>  and are considered improvement but *does not implement any functionality* 
> related to JPMS module support.
> Changes:
> * Maven4 should stop "disconnected coexistence" of two type systems 
> (ArtifactHandlers and Resolver ArtifactTypeRegistry), it should unify them.
> * Maven4 Core should provide generic and extensible means to introduce new 
> artifact types (fully in extension, and extension should get extended data 
> via "roundtrip" in core/resolver)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to