[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787961#comment-17787961
 ] 

ASF GitHub Bot commented on MBUILDCACHE-74:
-------------------------------------------

mweirauch opened a new pull request, #110:
URL: https://github.com/apache/maven-build-cache-extension/pull/110

   This MR cleans up any cached local build, no matter if the module/project in 
question has a package phase.
   
   I noticed stale cache entries for our parent POM in the local build cache, 
which were not cleaned up.
   
   --
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [MBUILDCACHE JIRA 
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue. 
Best practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Old POM builds are not cleaned up from local cache
> --------------------------------------------------
>
>                 Key: MBUILDCACHE-74
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-74
>             Project: Maven Build Cache Extension
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>            Reporter: Michael Weirauch
>            Priority: Minor
>
> We are operating a multi-module mono repository with an in-tree parent which 
> is used by all modules. The parent is modified regularly. While debugging I 
> realized that stale cache entries for the parent are still present in the 
> local build cache directory allthough "maxBuildsCached" is set to "1".
> I have a fix ready, but I am still trying to figure if I can hook into an 
> existing test or create a dedicated one. (I am not that familiar with the 
> codebase.)
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to