[
https://issues.apache.org/jira/browse/MBUILDCACHE-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788636#comment-17788636
]
ASF GitHub Bot commented on MBUILDCACHE-74:
-------------------------------------------
mweirauch commented on code in PR #110:
URL:
https://github.com/apache/maven-build-cache-extension/pull/110#discussion_r1401527968
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -503,6 +503,7 @@ public void save(
}
}
} else {
+ localCache.beforeSave(context);
Review Comment:
Oh sorry, I should have left a comment in the MR intially ...
While checking existing issues, I stumbled upon MBUILDCACHE-71 (only publish
buildinfo after optional artifacts were pushed) and tried to pull both calls
(::beforeSave and ::saveBuildInfo) actually down/below the "if", but that makes
Issue67Test actually fail.
I'll try to have a look what the expectations are on Issue67Test, but my
time is a bit limited. So is the proposoal to move both statements above the
"if" and dropping the "else branch" acceptable for the moment?
> Old POM builds are not cleaned up from local cache
> --------------------------------------------------
>
> Key: MBUILDCACHE-74
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-74
> Project: Maven Build Cache Extension
> Issue Type: Bug
> Affects Versions: 1.0.1
> Reporter: Michael Weirauch
> Priority: Minor
> Labels: pull-request-available
>
> We are operating a multi-module mono repository with an in-tree parent which
> is used by all modules. The parent is modified regularly. While debugging I
> realized that stale cache entries for the parent are still present in the
> local build cache directory allthough "maxBuildsCached" is set to "1".
> I have a fix ready, but I am still trying to figure if I can hook into an
> existing test or create a dedicated one. (I am not that familiar with the
> codebase.)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
