[
https://issues.apache.org/jira/browse/MCOMPILER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789367#comment-17789367
]
Jorge Solórzano commented on MCOMPILER-542:
-------------------------------------------
{quote}too chatty: that's why I proposed just a single summary at the end of
the patch, to know that the patch was activated and how much it had to patch.
More detail, even in debug, is too much noise IMHO
{quote}
Sure, I added a summary at the end of the patch printing all the modules that
were patched, right now is with info level to not be a silent feature, can be
changed to debug or whatever.
{quote}notice that even if JDK 22 has the fix, I expect Reproducible Builds
releases to be done with the next LTS, in near 2 years, because building
releases to Maven Central with a non LTS compiler is not a best practice
{quote}
In general, this is always activated (or the Reproducible Builds will not
work), I tried to add some conditionals to skip versions > 21 where the JDK fix
will be available, but I reverted that since I could not simply use the
{{java.specification.version}} to check the java version used since I also
have to check the toolchain used, so is not so trivial to add this check, it
should not be a blocker since the JDK fix will be released the next year and I
don't expect everyone building with JDK 22 in the short term, this skip based
on JDK could be added in a next version of m-compiler-p. WDYT?
> clean JDK patch version in module-info.class
> --------------------------------------------
>
> Key: MCOMPILER-542
> URL: https://issues.apache.org/jira/browse/MCOMPILER-542
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Affects Versions: 3.11.0
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
> Fix For: 3.12.0
>
>
> as seen in MJAR-275, JDK patch version in module-info.class is NOT included
> only when building with a newer JDK release using "--release" flag, see
> [https://github.com/jvm-repo-rebuild/module-info]
> issue [https://bugs.openjdk.org/browse/JDK-8318913] created in JDK to get a
> proper fix at javac level (probably for Java 22)
> and waiting for that, we need a workaround to drop the JDK patch version in
> other cases: we'll need to define where is the best place –
> m-jar-p?m-compiler-p? other?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
