[
https://issues.apache.org/jira/browse/MNG-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810809#comment-17810809
]
ASF GitHub Bot commented on MNG-8026:
-------------------------------------
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466175527
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##########
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+ /**
+ * The artifact properties.
+ *
+ * @return the artifact properties, never {@code null}
+ */
+ @Nonnull
+ ArtifactProperties getArtifactProperties();
Review Comment:
No, `Type` is a property of `Dependency`. What happens is that is just an
indirection of `Type` -> `properties`. If you think about, EVERY Artifact (sans
root) have type (as they enter scope as dependencies of root).
And yes, am looking at Resolver API as it is done well and works. IMO we
should really just pull a thin layer on top of it for start, that we can refine
later. But in general, this is how things should work, really.
> Maven should define from ground up scopes used with Resolver
> ------------------------------------------------------------
>
> Key: MNG-8026
> URL: https://issues.apache.org/jira/browse/MNG-8026
> Project: Maven
> Issue Type: Task
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> See MRESOLVER-471, it is actually role of Maven (as a resolver consumer
> project) to define all these things:
> * supported scopes
> * transformations of scopes to build path scopes
> * fine tune conflict resolution and related things (in session)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
