[ 
https://issues.apache.org/jira/browse/MNG-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810839#comment-17810839
 ] 

ASF GitHub Bot commented on MNG-8026:
-------------------------------------

gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466213690


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##########
@@ -105,6 +105,14 @@ default String key() {
      */
     boolean isSnapshot();
 
+    /**
+     * The artifact properties.
+     *
+     * @return the artifact properties, never {@code null}
+     */
+    @Nonnull
+    ArtifactProperties getArtifactProperties();

Review Comment:
   > Sorry, used wrong lingo. You are right "artifact resolve" is really "just 
download that single file for that artifact, no deps involved". I was talking 
about `collect+resolve` that is the main use case of Resolver, as there, all 
the artifacts you end up with (resolved) are dependencies except the root, but 
that one as well may have properties if you used `ArtifactType` to construct it.
   
   That's exactly why I think we should keep things split more clearly between 
Artifact and Dependency.  We have artifacts which are related to repositories 
and dependencies for... dependencies.  Different words for different meanings.  
We should make that more clear rather than blur things...





> Maven should define from ground up scopes used with Resolver
> ------------------------------------------------------------
>
>                 Key: MNG-8026
>                 URL: https://issues.apache.org/jira/browse/MNG-8026
>             Project: Maven
>          Issue Type: Task
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> See MRESOLVER-471, it is actually role of Maven (as a resolver consumer 
> project) to define all these things:
>  * supported scopes
>  * transformations of scopes to build path scopes
>  * fine tune conflict resolution and related things (in session)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to