[
https://issues.apache.org/jira/browse/MNG-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814808#comment-17814808
]
ASF GitHub Bot commented on MNG-8043:
-------------------------------------
gnodet commented on code in PR #1399:
URL: https://github.com/apache/maven/pull/1399#discussion_r1479788898
##########
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##########
@@ -92,7 +92,7 @@ public enum DependencyScope {
* System scope.
* <p>
* Important: this scope {@code id} MUST BE KEPT in sync with label in
- * {@code org.eclipse.aether.util.artifact.Scopes#SYSTEM}.
+ * {@code org.eclipse.aether.util.artifact.DependencyScopes#SYSTEM}.
Review Comment:
We should add a provider spi in resolver (or in the session, whereever it
makes sense), to avoid this "must be KEPT in sync" as the resolver should be
given the name of the system scope and not impose it.
> Dependency properties should be provided by Resolver consumer
> -------------------------------------------------------------
>
> Key: MNG-8043
> URL: https://issues.apache.org/jira/browse/MNG-8043
> Project: Maven
> Issue Type: Task
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Follow up of MRESOLVER-484
> The consumer, in this case Maven is the one who should provide Maven-specific
> bits. Also, do not use deprecated stuff from Resolver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
