[
https://issues.apache.org/jira/browse/MNG-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814908#comment-17814908
]
ASF GitHub Bot commented on MNG-8043:
-------------------------------------
cstamas commented on code in PR #1399:
URL: https://github.com/apache/maven/pull/1399#discussion_r1480303555
##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/type/DefaultType.java:
##########
@@ -95,8 +101,8 @@ public Map<String, String> getProperties() {
Map<String, String> properties = new HashMap<>();
properties.put(ArtifactProperties.TYPE, this.id);
properties.put(ArtifactProperties.LANGUAGE, this.language.id());
- properties.put(ArtifactProperties.INCLUDES_DEPENDENCIES,
String.valueOf(includesDependencies));
- properties.put(ArtifactProperties.CONSTITUTES_BUILD_PATH,
String.valueOf(buildPathConstituent));
+ properties.put(MavenArtifactProperties.INCLUDES_DEPENDENCIES,
String.valueOf(includesDependencies));
+ properties.put(MavenArtifactProperties.CONSTITUTES_BUILD_PATH,
String.valueOf(buildPathConstituent));
return Collections.unmodifiableMap(properties);
Review Comment:
fixed
> Dependency properties should be provided by Resolver consumer
> -------------------------------------------------------------
>
> Key: MNG-8043
> URL: https://issues.apache.org/jira/browse/MNG-8043
> Project: Maven
> Issue Type: Task
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Follow up of MRESOLVER-484
> The consumer, in this case Maven is the one who should provide Maven-specific
> bits. Also, do not use deprecated stuff from Resolver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
