[
https://issues.apache.org/jira/browse/MJLINK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816364#comment-17816364
]
ASF GitHub Bot commented on MJLINK-79:
--------------------------------------
YaSuenag opened a new pull request, #196:
URL: https://github.com/apache/maven-jlink-plugin/pull/196
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MJLINK-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- See [JIRA](https://issues.apache.org/jira/browse/MJLINK-79) for
details
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> addOptions should not quote option strings
> ------------------------------------------
>
> Key: MJLINK-79
> URL: https://issues.apache.org/jira/browse/MJLINK-79
> Project: Maven JLink Plugin
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Yasumasa Suenaga
> Priority: Major
>
> I configured maven-jlink-plugin as following:
> {code:java}
> <addOptions>
> <addOption>-XX:+HeapDumpOnOutOfMemoryError</addOption>
> <addOption>-XX:+UseParallelOldGC</addOption>
> </addOptions> {code}
> I saw following error when I run jlink'ed binary:
> {code:java}
> $ ./target/maven-jlink/classifiers/linux-amd64/bin/test
> Unrecognized VM option 'HeapDumpOnOutOfMemoryError -XX:+UseParallelOldGC'
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit. {code}
> JLinkMojo.java would quote option string like
> {noformat}
> String.format("\"%s\"", String.join(" ", addOptions)){noformat}
> However it should not do that because jlink would run jlink implementation
> which comes from ToolProvider, not on the shell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
