[
https://issues.apache.org/jira/browse/MJLINK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824901#comment-17824901
]
ASF GitHub Bot commented on MJLINK-79:
--------------------------------------
YaSuenag commented on PR #196:
URL:
https://github.com/apache/maven-jlink-plugin/pull/196#issuecomment-1986732996
PING: could you review this PR?
> addOptions should not quote option strings
> ------------------------------------------
>
> Key: MJLINK-79
> URL: https://issues.apache.org/jira/browse/MJLINK-79
> Project: Maven JLink Plugin
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Yasumasa Suenaga
> Priority: Major
>
> I configured maven-jlink-plugin as following:
> {code:java}
> <addOptions>
> <addOption>-XX:+HeapDumpOnOutOfMemoryError</addOption>
> <addOption>-XX:+UseParallelOldGC</addOption>
> </addOptions> {code}
> I saw following error when I run jlink'ed binary:
> {code:java}
> $ ./target/maven-jlink/classifiers/linux-amd64/bin/test
> Unrecognized VM option 'HeapDumpOnOutOfMemoryError -XX:+UseParallelOldGC'
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit. {code}
> JLinkMojo.java would quote option string like
> {noformat}
> String.format("\"%s\"", String.join(" ", addOptions)){noformat}
> However it should not do that because jlink would run jlink implementation
> which comes from ToolProvider, not on the shell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
