cstamas commented on code in PR #428:
URL: https://github.com/apache/maven-resolver/pull/428#discussion_r1485317539
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##########
@@ -394,8 +393,8 @@ protected VersionRangeResult cachedResolveRangeResult(
return rangeResult;
}
- protected static boolean isLackingDescriptor(Artifact artifact) {
- return artifact.getProperty(ArtifactProperties.LOCAL_PATH, null) !=
null;
+ protected static boolean isLackingDescriptor(RepositorySystemSession
session, Artifact artifact) {
+ return
session.getSystemScopeHandler().getSystemPath(artifact.getProperties()) != null;
Review Comment:
This makes me think that "system" scope and an "artifact with LOCAL_PATH
having set" are one and same (are same thing, synonyms so to say). We may want
to handle that as one, instead to have them separated?
Still, especially in depMgt, there are cases where path is unset, but scope
remains... so maybe this "handler" is still ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
