cstamas commented on code in PR #428:
URL: https://github.com/apache/maven-resolver/pull/428#discussion_r1485956826
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##########
@@ -394,8 +393,8 @@ protected VersionRangeResult cachedResolveRangeResult(
return rangeResult;
}
- protected static boolean isLackingDescriptor(Artifact artifact) {
- return artifact.getProperty(ArtifactProperties.LOCAL_PATH, null) !=
null;
+ protected static boolean isLackingDescriptor(RepositorySystemSession
session, Artifact artifact) {
+ return
session.getSystemScopeHandler().getSystemPath(artifact.getProperties()) != null;
Review Comment:
If you look at "system" scope definition, there is this sentence "Dependency
in this scope does not have artifact descriptor either.". And this here is the
check "does it have descriptor. And since Resolver 1.0 the actual check is done
like this: `artifact.getProperty( ArtifactProperties.LOCAL_PATH, null ) !=
null` (presence of property and not actual scope).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
