[
https://issues.apache.org/jira/browse/MRESOLVER-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816426#comment-17816426
]
ASF GitHub Bot commented on MRESOLVER-494:
------------------------------------------
gnodet commented on code in PR #428:
URL: https://github.com/apache/maven-resolver/pull/428#discussion_r1485605455
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java:
##########
@@ -394,8 +393,8 @@ protected VersionRangeResult cachedResolveRangeResult(
return rangeResult;
}
- protected static boolean isLackingDescriptor(Artifact artifact) {
- return artifact.getProperty(ArtifactProperties.LOCAL_PATH, null) !=
null;
+ protected static boolean isLackingDescriptor(RepositorySystemSession
session, Artifact artifact) {
+ return
session.getSystemScopeHandler().getSystemPath(artifact.getProperties()) != null;
Review Comment:
I'm not really sure to understand what you're suggesting here...
> LOCAL_PATH Artifact property really belongs to "system" scope (or is at least
> very related to it)
> -------------------------------------------------------------------------------------------------
>
> Key: MRESOLVER-494
> URL: https://issues.apache.org/jira/browse/MRESOLVER-494
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0-alpha-8, 2.0.0
>
>
> LOCAL_PATH Artifact property really belongs to "system" scope (or is at least
> very related to it).
> It may need to be removed as well?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
