[ 
https://issues.apache.org/jira/browse/MRESOLVER-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816609#comment-17816609
 ] 

ASF GitHub Bot commented on MRESOLVER-494:
------------------------------------------

slawekjaranowski commented on code in PR #428:
URL: https://github.com/apache/maven-resolver/pull/428#discussion_r1486203871


##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/AbstractDependencyManager.java:
##########
@@ -43,7 +42,7 @@ public abstract class AbstractDependencyManager implements 
DependencyManager {
      * @deprecated To be removed when deprecated constructors are removed.
      */
     @Deprecated
-    protected static final SystemScopePredicate SYSTEM_PREDICATE = 
"system"::equals;
+    protected static final SystemScopeHandler SYSTEM_PREDICATE = 
SystemScopeHandler.LEGACY;

Review Comment:
   SYSTEM_PREDICATE -> SYSTEM_SCOPE_HANDLER





> LOCAL_PATH Artifact property really belongs to "system" scope (or is at least 
> very related to it)
> -------------------------------------------------------------------------------------------------
>
>                 Key: MRESOLVER-494
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-494
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0-alpha-8, 2.0.0
>
>
> LOCAL_PATH Artifact property really belongs to "system" scope (or is at least 
> very related to it).
> It may need to be removed as well?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to