[
https://issues.apache.org/jira/browse/MRESOLVER-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822100#comment-17822100
]
ASF GitHub Bot commented on MRESOLVER-502:
------------------------------------------
michael-o commented on code in PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#discussion_r1507432682
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:
##########
@@ -64,6 +68,30 @@
@Singleton
@Named
public class DefaultInstaller implements Installer {
+ private class DeferredInstallRequest implements Runnable {
+ private final RepositorySystemSession session;
+ private final SyncContextFactory syncContextFactory;
+ private final CopyOnWriteArrayList<InstallRequest> requests;
+
+ private DeferredInstallRequest(RepositorySystemSession session,
SyncContextFactory syncContextFactory) {
+ this.session = session;
+ this.syncContextFactory = syncContextFactory;
+ this.requests = new CopyOnWriteArrayList<>();
+ }
+
+ @Override
+ public void run() {
+ try (SyncContext syncContext =
syncContextFactory.newInstance(session, false)) {
+ for (InstallRequest request : requests) {
+ install(syncContext, session, request);
+ }
+ } catch (InstallationException e) {
+ logger.warn("Failure during deferred installation:", e);
Review Comment:
same here
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:
##########
@@ -83,6 +86,30 @@
@Singleton
@Named
public class DefaultDeployer implements Deployer {
+ private class DeferredDeployRequest implements Runnable {
+ private final RepositorySystemSession session;
+ private final SyncContextFactory syncContextFactory;
+ private final CopyOnWriteArrayList<DeployRequest> requests;
+
+ private DeferredDeployRequest(RepositorySystemSession session,
SyncContextFactory syncContextFactory) {
+ this.session = session;
+ this.syncContextFactory = syncContextFactory;
+ this.requests = new CopyOnWriteArrayList<>();
+ }
+
+ @Override
+ public void run() {
+ try (SyncContext syncContext =
syncContextFactory.newInstance(session, false)) {
+ for (DeployRequest request : requests) {
+ deploy(syncContext, session, request);
+ }
+ } catch (DeploymentException e) {
+ logger.warn("Failure during deferred deployment:", e);
Review Comment:
Colon is redundant
> Install/Deploy at session end
> -----------------------------
>
> Key: MRESOLVER-502
> URL: https://issues.apache.org/jira/browse/MRESOLVER-502
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-9
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
