[ 
https://issues.apache.org/jira/browse/MRESOLVER-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822273#comment-17822273
 ] 

ASF GitHub Bot commented on MRESOLVER-502:
------------------------------------------

cstamas commented on PR #437:
URL: https://github.com/apache/maven-resolver/pull/437#issuecomment-1971738341

   > I'm not really convinced. I don't think the logic in the resolver is very 
different from the one in the install/deploy plugin
   
   Is a LOT different. Here, it is really plain straight forward, while in 
plugins it does hoops and loops to:
   * figure out "is it end" (w/ respect of multi module builds, parallel 
builds, etc)?
   * figure modules in reactor that may not use install plugin and consider 
them as well
   * keep state and do something wildly different if "not end"
   * etc.
   
   Here, Installer/Deployer simply gets the "done done" list of artifacts that 
are to be installed. And done.
   
   And plugins just "install/deploy", no logic, they are no brainer, and IMHO 
corresponding logic (here in this PR) is also much much simpler. 
   
   Btw, it is a sign that "deploy at end" was not solved properly for so long...




> Install/Deploy at session end
> -----------------------------
>
>                 Key: MRESOLVER-502
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-502
>             Project: Maven Resolver
>          Issue Type: New Feature
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-9
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to