rmannibucau commented on PR #1437: URL: https://github.com/apache/maven/pull/1437#issuecomment-1987170365
> You should not assume maven-core(-plugins) inability to adapt to never features to everyone, e.g. Tycho always uses latest maven and latest features I didn't at all, even the opposite if you read carefully. I just highlight you create a concurrent feature of something existing in latest version of the project - indeed it needs a few adjustment but it does not need the proposed PR. > "by default" Maven can't know what is desired for a consumer pom Then you don't speak about consumer pom which is well defined as a consummable pom by downstream builds (v4.0.0), anything else is not consumer pom and does not belong to core IMO - I suspect even if not sure you want some tycho meta but this is not about consumer pom IMHO, potentially main pom but consumer has another intent. > I can't see how maven could ever handle this automatically given that.. Consumer pom is built form the model, if you fill the model you get a valid consumer pom. > where current solution has undesired side-effect and only looks at project.getFile() In maven 3 there isnt really a notion of consumer pom (we had some proto but no real API) so it is mainly about a single v4.0.0 pom you were able to mutate. Indeed it has side effects but similarly your consumer pom will have exactly the same since it has the exact same design and all plugins will not always agree on that (current pitfall). This is why it is important to use the model IMHO and let the tranformer create a valid shareable and backward compat consumer pom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
