laeubi commented on PR #1437:
URL: https://github.com/apache/maven/pull/1437#issuecomment-1987173800

   > Consumer pom is built form the model, if you fill the model you get a 
valid consumer pom.
   
   Just look here:
   
   
https://github.com/apache/maven/blob/33788fd7fc33932639d1a600eada36e3cd015bfd/maven-core/src/main/java/org/apache/maven/internal/transformation/impl/DefaultConsumerPomArtifactTransformer.java#L79
   
   and here:
   
   
https://github.com/apache/maven/blob/33788fd7fc33932639d1a600eada36e3cd015bfd/maven-core/src/main/java/org/apache/maven/internal/transformation/impl/DefaultConsumerPomArtifactTransformer.java#L109
   
   and finally here:
   
   
https://github.com/apache/maven/blob/33788fd7fc33932639d1a600eada36e3cd015bfd/maven-core/src/main/java/org/apache/maven/internal/transformation/impl/DefaultConsumerPomBuilder.java#L201
   
   for me it looks like it is reading this file, not the (in memory) pom ...
   
   > Then you don't speak about consumer pom which is well defined as a 
consummable pom by downstream builds (v4.0.0), anything else is not consumer 
pom and does not belong to core IMO - I suspect even if not sure you want some 
tycho meta but this is not about consumer pom IMHO, potentially main pom but 
consumer has another intent.
   
   I'm defiantly talking about consumer pom, because consumers ( == plain 
maven) wants to have a pom that they can consume without Tycho (Tycho itself 
don't need a physical pom.xml). So if you build some jar with Tycho you want it 
to be consumable after you deployed it to central by others (non Tycho users) 
like a traditionally hand written pom.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to