[
https://issues.apache.org/jira/browse/MNG-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827822#comment-17827822
]
ASF GitHub Bot commented on MNG-8069:
-------------------------------------
elharo commented on code in PR #1435:
URL: https://github.com/apache/maven/pull/1435#discussion_r1527655423
##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+ MavenSession session = event.getSession();
+ MavenExecutionResult result = session.getResult();
+ ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+ List<MavenProject> upstreamProjects;
+ if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+ && projectDependencyGraph != null) {
+
+ // the project is blacklisted only so one of its upstreams
must have failed here...
+ upstreamProjects =
projectDependencyGraph.getUpstreamProjects(event.getProject(), true);
+ } else {
+ // any other failure must have lead to this so any projects is
eligible
Review Comment:
are eligible
##########
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
##########
@@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {
if (logger.isInfoEnabled()) {
logger.info("");
infoLine('-');
+ MavenSession session = event.getSession();
+ MavenExecutionResult result = session.getResult();
+ ProjectDependencyGraph projectDependencyGraph =
session.getProjectDependencyGraph();
+ List<MavenProject> upstreamProjects;
+ if
(MavenExecutionRequest.REACTOR_FAIL_AT_END.equals(session.getReactorFailureBehavior())
+ && projectDependencyGraph != null) {
+
+ // the project is blacklisted only so one of its upstreams
must have failed here...
Review Comment:
I can't quite follow this comment, please rephrase
> Message "This project has been banned from the build due to previous
> failures." is too unspecific
> -------------------------------------------------------------------------------------------------
>
> Key: MNG-8069
> URL: https://issues.apache.org/jira/browse/MNG-8069
> Project: Maven
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> Currently if a multimodule build fails (either fast or at the end), the user
> gets a message in the log that reads:
> {quote}This project has been banned from the build due to previous
> failures.{quote}
>
> this is correct but does not give a hint *what* has failed and one needs to
> investigate the build logs to get more details.
> Instead the message should show the actual project that make it impossible to
> build this and is the reason fro this project being banned.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
