Marcono1234 opened a new pull request, #219:

   Currently the Mojo documentation does not mention the default for these 
parameters, which will be confusing for the user. Have for example a look at 
the current 
documentation; you will see that for all the changed parameters no default 
value is currently documented. So it is not clear whether these parameters 
apply by default.
   Please let me know if I forget to consider something and this change has any 
undesired side effects.
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
    - [ ] Make sure there is a [JIRA 
issue]( filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[MSHADE-XXX] - Fixes bug in 
          where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best 
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [x] You have run the integration tests successfully (`mvn -Prun-its clean 
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement]( if you are unsure
   please ask on the developers list.
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
   you have to acknowledge this by using the following check-box.
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

For queries about this service, please contact Infrastructure at:

Reply via email to