Marcono1234 commented on code in PR #219: URL: https://github.com/apache/maven-shade-plugin/pull/219#discussion_r1554398907
########## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ########## @@ -197,7 +197,7 @@ public class ShadeMojo extends AbstractMojo { * <p/> * If you like to change the name of the native artifact, you may use the <build><finalName> setting. If this * is set to something different than <build><finalName>, no file replacement will be performed, even if - * shadedArtifactAttached is being used. + * {@link #shadedArtifactAttached} is false. Review Comment: Is this change correct? If I understood it correctly, if `<build><finalName>` and the Mojo `<finalName>` differ then the main project artifact will not be replaced, even if `shadedArtifactAttached=false`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org