[
https://issues.apache.org/jira/browse/MENFORCER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869677#comment-17869677
]
ASF GitHub Bot commented on MENFORCER-508:
------------------------------------------
kwin opened a new pull request, #328:
URL: https://github.com/apache/maven-enforcer/pull/328
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Extend requireSameVersions rule to optionally enforce same versions among
> reactor modules
> -----------------------------------------------------------------------------------------
>
> Key: MENFORCER-508
> URL: https://issues.apache.org/jira/browse/MENFORCER-508
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: requireSameVersions
> Affects Versions: 3.5.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Currently the rule
> [https://maven.apache.org/enforcer/enforcer-rules/requireSameVersions.html]
> does not support checking versions of the actual Maven modules (but only of
> contained dependencies and/or plugins). Often it is important that all
> modules of an aggregator project share a common version (in order to
> ease/allow releases). I propose to add an additional flag
> {{sameModuleVersions}} which if set to {{true}} enforces all modules built
> from the reactor root share a common version. This should also support
> [CI-friendly versions|https://maven.apache.org/maven-ci-friendly.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
