[ 
https://issues.apache.org/jira/browse/MENFORCER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872580#comment-17872580
 ] 

ASF GitHub Bot commented on MENFORCER-508:
------------------------------------------

slawekjaranowski commented on code in PR #328:
URL: https://github.com/apache/maven-enforcer/pull/328#discussion_r1712637137


##########
enforcer-rules/src/site/apt/requireSameVersions.apt.vm:
##########
@@ -37,8 +37,10 @@
    * <<reportPlugins>> - an optional list of report plugin patterns
    
    * <<plugins>> - an optional list of both build and report plugin patterns
-    
+   
    * <<uniqueVersions>> - if SNAPSHOTs should be compared by their timestamped 
version or not. Default: false
+   
+   * <<sameModuleVersions>> - if set to true enforces that the current module 
has the same version as the top level aggregator project. Default: false. 
Supported since version 3.6.0

Review Comment:
   hint can stay - no problem for me





> Extend requireSameVersions rule to optionally enforce same versions among 
> reactor modules
> -----------------------------------------------------------------------------------------
>
>                 Key: MENFORCER-508
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-508
>             Project: Maven Enforcer Plugin
>          Issue Type: Improvement
>          Components: requireSameVersions
>    Affects Versions: 3.5.0
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> Currently the rule 
> [https://maven.apache.org/enforcer/enforcer-rules/requireSameVersions.html] 
> does not support checking versions of the actual Maven modules (but only of 
> contained dependencies and/or plugins). Often it is important that all 
> modules of an aggregator project share a common version (in order to 
> ease/allow releases). I propose to add an additional flag 
> {{sameModuleVersions}} which if set to {{true}} enforces all modules built 
> from the reactor root share a common version. This should also support 
> [CI-friendly versions|https://maven.apache.org/maven-ci-friendly.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to