gnodet commented on code in PR #1660:
URL: https://github.com/apache/maven/pull/1660#discussion_r1731523749
##########
src/mdo/model.vm:
##########
@@ -493,40 +482,15 @@ public class ${class.name}
#end
@Nonnull
public ${class.name} build() {
+ // this method should not contain any logic other than creating
the object in order to ease subclassing
Review Comment:
Is that a hint that the below code should be removed ? If so, I disagree,
as this is an important optimisation.
If not, maybe the line should be removed or made more explicit...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
