kwin commented on code in PR #1660:
URL: https://github.com/apache/maven/pull/1660#discussion_r1732258290
##########
src/mdo/model.vm:
##########
@@ -493,40 +482,15 @@ public class ${class.name}
#end
@Nonnull
public ${class.name} build() {
+ // this method should not contain any logic other than creating
the object in order to ease subclassing
Review Comment:
No it isn't, this needs to be kept as optimization. I clarified the comment
in
https://github.com/apache/maven/pull/1660/commits/effa73709e4b49a9509f0891ee3c6225b0b9a02c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
