mthmulders commented on code in PR #615: URL: https://github.com/apache/maven-site/pull/615#discussion_r1899176844
########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env + rectangle lib + } +} + +'hidden dependencies to change layout +Archetypes -[hidden]right-> Poms +Poms -[hidden]right-> Skins +Skins -[hidden]right-> Studies +Studies -[hidden]right-> Indexer +Indexer -[hidden]right-> Wagon +Wagon -[hidden]right-> "Plugin testing" + +Archetypes -[hidden]down-> "dist-tool" Review Comment: The readme calls this one "Distribution Tool Plugin". ```suggestion Archetypes -[hidden]down-> "Distribution Tool Plugin" ``` ########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env + rectangle lib + } +} + +'hidden dependencies to change layout +Archetypes -[hidden]right-> Poms +Poms -[hidden]right-> Skins +Skins -[hidden]right-> Studies +Studies -[hidden]right-> Indexer +Indexer -[hidden]right-> Wagon +Wagon -[hidden]right-> "Plugin testing" + +Archetypes -[hidden]down-> "dist-tool" +"dist-tool" -[hidden]right-> Jenkins + +url of "Archetypes" is [[https://github.com/apache/maven-archetype]] +url of Poms is [[https://github.com/apache/maven-parent]] +url of Skins is [[https://github.com/apache/maven-skins]] +url of Studies is [[https://github.com/apache/maven-studies]] +url of Indexer is [[https://github.com/apache/maven-indexer]] +url of Wagon is [[hhttps://github.com/apache/maven-wagon]] +url of "Plugin testing" is [[https://github.com/apache/maven-plugin-testing]] +url of "dist-tool" is [[https://github.com/apache/maven-dist-tool]] Review Comment: ```suggestion url of "Distribution Tool Plugin" is [[https://github.com/apache/maven-dist-tool]] ``` ########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env + rectangle lib + } +} + +'hidden dependencies to change layout +Archetypes -[hidden]right-> Poms +Poms -[hidden]right-> Skins +Skins -[hidden]right-> Studies +Studies -[hidden]right-> Indexer +Indexer -[hidden]right-> Wagon +Wagon -[hidden]right-> "Plugin testing" + +Archetypes -[hidden]down-> "dist-tool" +"dist-tool" -[hidden]right-> Jenkins + +url of "Archetypes" is [[https://github.com/apache/maven-archetype]] +url of Poms is [[https://github.com/apache/maven-parent]] +url of Skins is [[https://github.com/apache/maven-skins]] +url of Studies is [[https://github.com/apache/maven-studies]] +url of Indexer is [[https://github.com/apache/maven-indexer]] +url of Wagon is [[hhttps://github.com/apache/maven-wagon]] +url of "Plugin testing" is [[https://github.com/apache/maven-plugin-testing]] +url of "dist-tool" is [[https://github.com/apache/maven-dist-tool]] +url of env is [[https://github.com/apache/maven-jenkins-env]] Review Comment: ```suggestion url of Environment is [[https://github.com/apache/maven-jenkins-env]] ``` ########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env + rectangle lib + } +} + +'hidden dependencies to change layout +Archetypes -[hidden]right-> Poms +Poms -[hidden]right-> Skins +Skins -[hidden]right-> Studies +Studies -[hidden]right-> Indexer +Indexer -[hidden]right-> Wagon +Wagon -[hidden]right-> "Plugin testing" + +Archetypes -[hidden]down-> "dist-tool" +"dist-tool" -[hidden]right-> Jenkins + +url of "Archetypes" is [[https://github.com/apache/maven-archetype]] +url of Poms is [[https://github.com/apache/maven-parent]] +url of Skins is [[https://github.com/apache/maven-skins]] +url of Studies is [[https://github.com/apache/maven-studies]] +url of Indexer is [[https://github.com/apache/maven-indexer]] +url of Wagon is [[hhttps://github.com/apache/maven-wagon]] +url of "Plugin testing" is [[https://github.com/apache/maven-plugin-testing]] +url of "dist-tool" is [[https://github.com/apache/maven-dist-tool]] +url of env is [[https://github.com/apache/maven-jenkins-env]] +url of lib is [[https://github.com/apache/maven-jenkins-lib]] Review Comment: ```suggestion url of "Shared Libraries" is [[https://github.com/apache/maven-jenkins-lib]] ``` ########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env Review Comment: According to the readme, it is "Apache Maven Jenkins Environment" ```suggestion rectangle Environment ``` ########## src/plantuml/maven-sources/plexus.puml: ########## @@ -0,0 +1,47 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor Yellow + } +} +</style> + +package "Plexus" { + rectangle "utils" Review Comment: Only for consistency with "Classworlds" and "Modello" ```suggestion rectangle "Utils" ``` ########## src/plantuml/maven-sources/plexus.puml: ########## @@ -0,0 +1,47 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor Yellow + } +} +</style> + +package "Plexus" { + rectangle "utils" + ' rectangle "Components" + rectangle "Classworlds" + rectangle "Modello" +} + +'hidden dependencies to change layout +' "utils" -[hidden]right-> "Components" +' "Components" -[hidden]right-> "Classworlds" +"utils" -[hidden]right-> "Classworlds" Review Comment: ```suggestion "Utils" -[hidden]right-> "Classworlds" ``` ########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env + rectangle lib + } +} + +'hidden dependencies to change layout +Archetypes -[hidden]right-> Poms +Poms -[hidden]right-> Skins +Skins -[hidden]right-> Studies +Studies -[hidden]right-> Indexer +Indexer -[hidden]right-> Wagon +Wagon -[hidden]right-> "Plugin testing" + +Archetypes -[hidden]down-> "dist-tool" +"dist-tool" -[hidden]right-> Jenkins Review Comment: ```suggestion "Distribution Tool Plugin" -[hidden]right-> Jenkins ``` ########## src/plantuml/maven-sources/misc.puml: ########## @@ -0,0 +1,66 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor LightBlue + } +} +</style> + +package Misc { + rectangle Archetypes + rectangle Poms + rectangle Skins + rectangle Studies + rectangle Indexer + rectangle Wagon + rectangle "Plugin testing" + rectangle "dist-tool" + package Jenkins { + rectangle env + rectangle lib Review Comment: According to the readme, it is "Apache Maven Jenkins Shared Libraries" ```suggestion rectangle "Shared Libraries" ``` ########## src/plantuml/maven-sources/plexus.puml: ########## @@ -0,0 +1,47 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor Yellow + } +} +</style> + +package "Plexus" { + rectangle "utils" + ' rectangle "Components" + rectangle "Classworlds" + rectangle "Modello" +} + +'hidden dependencies to change layout +' "utils" -[hidden]right-> "Components" +' "Components" -[hidden]right-> "Classworlds" +"utils" -[hidden]right-> "Classworlds" +"Classworlds" -[hidden]right-> "Modello" + +url of "utils" is [[https://github.com/codehaus-plexus/plexus-utils]] Review Comment: ```suggestion url of "Utils" is [[https://github.com/codehaus-plexus/plexus-utils]] ``` ########## src/plantuml/maven-sources/plexus.puml: ########## @@ -0,0 +1,47 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor Yellow + } +} +</style> + +package "Plexus" { + rectangle "utils" + ' rectangle "Components" + rectangle "Classworlds" + rectangle "Modello" +} + +'hidden dependencies to change layout +' "utils" -[hidden]right-> "Components" +' "Components" -[hidden]right-> "Classworlds" +"utils" -[hidden]right-> "Classworlds" +"Classworlds" -[hidden]right-> "Modello" + +url of "utils" is [[https://github.com/codehaus-plexus/plexus-utils]] +' url of "Components" is [[https://github.com/codehaus-plexus/plexus-components]] Review Comment: Same as above: please explain why it is commented, or leave it out. ########## src/plantuml/maven-sources/plexus.puml: ########## @@ -0,0 +1,47 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ +@startuml +!pragma layout smetana + +<style> + rectangle { + BackgroundColor Yellow + } +} +</style> + +package "Plexus" { + rectangle "utils" + ' rectangle "Components" + rectangle "Classworlds" + rectangle "Modello" +} + +'hidden dependencies to change layout +' "utils" -[hidden]right-> "Components" +' "Components" -[hidden]right-> "Classworlds" Review Comment: Commented code puzzles me. Are the relationships there, but not relevant? Then please update the comment to explain it. Otherwise, can it be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
