[ 
https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925258#comment-17925258
 ] 

ASF GitHub Bot commented on MCOMPILER-529:
------------------------------------------

slawekjaranowski commented on code in PR #245:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/245#discussion_r1947771649


##########
src/site/apt/examples/set-compiler-source-and-target.apt.vm:
##########
@@ -82,3 +85,9 @@ Setting the <<<-source>>> and <<<-target>>> of the Java 
Compiler
   In the same way, setting the <<<source>>> option does not guarantee that 
your code actually compiles on a JDK with
   the specified version. To compile your code with a specific JDK version, 
different than the one used to launch Maven,
   refer to the {{{../examples/compile-using-different-jdk.html}Compile Using A 
Different JDK}} example.
+
+  <<Note:>> When you build your project using newer JDK (9+) you can also use 
"8" instead of "1.8" to set Java 8 as the

Review Comment:
   JDK 17 is minimum for 4.x





> Improve the docs about usage 1.8 vs. 8 for source/target
> --------------------------------------------------------
>
>                 Key: MCOMPILER-529
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-529
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.10.1
>            Reporter: Karl Heinz Marbaise
>            Assignee: Matthias Bünger
>            Priority: Minor
>              Labels: up-for-grabs
>
> The current descriptions/docs only mentioned the usage of {{1.8}} for 
> source/target. But it looks like I can use also {{8}} instead. But all the 
> examples on the usage page etc. using {{1.8}}... even the error message tells 
> me to do:
> {{code}}
> use -source 8 ...
> {{code}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to