[
https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925419#comment-17925419
]
ASF GitHub Bot commented on MCOMPILER-529:
------------------------------------------
slawekjaranowski commented on code in PR #295:
URL:
https://github.com/apache/maven-compiler-plugin/pull/295#discussion_r1948220919
##########
src/site/apt/examples/set-compiler-source-and-target.apt.vm:
##########
@@ -79,6 +83,9 @@ Setting the <<<-source>>> and <<<-target>>> of the Java
Compiler
{{{http://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/}Animal
Sniffer Maven Plugin}}
to verify your code doesn't use unintended APIs, or better yet use the
{{{../examples/set-compiler-release.html}<<<release>>> option supported
since JDK 9}}.
+ Since plugin version <<<3.13.0>>> you can use the <<<release>>> property
also on JDK 8.
+ The compiler plugin will convert it to <<<source>>> and <<<target>>>
automatically.
+
In the same way, setting the <<<source>>> option does not guarantee that
your code actually compiles on a JDK with
the specified version. To compile your code with a specific JDK version,
different than the one used to launch Maven,
- refer to the {{{../examples/compile-using-different-jdk.html}Compile Using A
Different JDK}} example.
+ refer to the {{{../examples/compile-using-different-jdk.html}Compile Using A
Different JDK}} example.
Review Comment:
missing new line at the end
> Improve the docs about usage 1.8 vs. 8 for source/target
> --------------------------------------------------------
>
> Key: MCOMPILER-529
> URL: https://issues.apache.org/jira/browse/MCOMPILER-529
> Project: Maven Compiler Plugin
> Issue Type: Improvement
> Affects Versions: 3.10.1
> Reporter: Karl Heinz Marbaise
> Assignee: Matthias Bünger
> Priority: Minor
> Labels: up-for-grabs
>
> The current descriptions/docs only mentioned the usage of {{1.8}} for
> source/target. But it looks like I can use also {{8}} instead. But all the
> examples on the usage page etc. using {{1.8}}... even the error message tells
> me to do:
> {{code}}
> use -source 8 ...
> {{code}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
