Pankraz76 commented on code in PR #2415:
URL: https://github.com/apache/maven/pull/2415#discussion_r2117683011
##########
compat/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java:
##########
@@ -62,19 +62,11 @@ public String pathOf(Artifact artifact) {
}
public String pathOfLocalRepositoryMetadata(ArtifactMetadata metadata,
ArtifactRepository repository) {
- return pathOfRepositoryMetadata(metadata.getLocalFilename(repository));
- }
-
- private String pathOfRepositoryMetadata(String filename) {
- StringBuilder path = new StringBuilder(128);
-
- path.append(filename);
-
- return path.toString();
+ return metadata.getLocalFilename(repository);
}
public String pathOfRemoteRepositoryMetadata(ArtifactMetadata metadata) {
- return pathOfRepositoryMetadata(metadata.getRemoteFilename());
+ return metadata.getRemoteFilename();
Review Comment:
why no default impl in interface its pure domain logic?
- https://github.com/apache/maven/pull/2402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
