elharo commented on code in PR #2415:
URL: https://github.com/apache/maven/pull/2415#discussion_r2117694456


##########
compat/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java:
##########
@@ -132,15 +132,7 @@ public boolean checkOutOfDate(Date lastModified) {
 
     @Override
     public String toString() {
-        StringBuilder buffer = new StringBuilder(64);
-        buffer.append("{enabled=");
-        buffer.append(enabled);
-        buffer.append(", checksums=");
-        buffer.append(checksumPolicy);
-        buffer.append(", updates=");
-        buffer.append(updatePolicy);
-        buffer.append('}');
-        return buffer.toString();
+        return "{enabled=" + enabled + ", checksums=" + checksumPolicy + ", 
updates=" + updatePolicy + '}';

Review Comment:
   don't do this; it's actively bad



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to