Pankraz76 commented on PR #2430: URL: https://github.com/apache/maven/pull/2430#issuecomment-2942996635
> the method call is exactly the solution of the duplication problem of the wiki link you mention **Agree.** However, the current implementation violates the DRY (Don't Repeat Yourself) principle because the logic is not placed where it belongs—during object initialization via the constructor. In my opinion, the core issue here is **duplication**. By following the "money" (i.e., the numbers), we can see **23 calls to the same method**—a clear indicator of redundancy. If code requires **search-and-replace edits**, that’s **always** a red flag (code smell) and warrants special attention due to the high risk involved. <img width="1817" alt="image" src="https://github.com/user-attachments/assets/f903d697-afc4-4b73-83d9-faad660807c9"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
